PARQUET-1392: Read multiple RowGroups at once into an Arrow table #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
changed the title
xhochy
force-pushed
the
PARQUET-1392
branch
3 times, most recently
from
617d49e
to
57da415
Compare
majetideepak
approved these changes
Aug 22, 2018
src/parquet/arrow/reader.cc
Outdated
|
|
||
| for (size_t i = 0; i < row_groups.size(); ++i) { | ||
| std::shared_ptr<Table> rg_table; | ||
| RETURN_NOT_OK(ReadRowGroup(row_groups[i], indices, &rg_table)); |
There was a problem hiding this comment.
a small optimization here is to use
std::vector<std::shared_ptr<Table>> tables(row_group.size(), nullptr) above and
use &tables[i] here. Afaik certain tools like Spark generate parquet files with many small RowGroups.
There was a problem hiding this comment.
I just saw your TODO. So this change might be less relevant.
There was a problem hiding this comment.
Still, added it as it saves some cycles.
|
+1 also. I will look at the remaining PR for cpp-1.5.0 this morning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to go with the more simplistic approach and only introduce a convenience API for now. Once is merged, I'll do some work that at least primitive arrays are read into a single Array in this path.