PARQUET-1630: add empty compression union for Bloom filter #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdblue review requested |
rdblue
reviewed
Aug 12, 2019
src/main/thrift/parquet.thrift
Outdated
| /** | ||
| * The compression used in the Bloom filter. | ||
| **/ | ||
| union BloomFilterCompression {} |
There was a problem hiding this comment.
I think there should be a BloomFilterCompression for Uncompressed so that implementations can check for it and ignore bloom filters if the compression doesn't match.
Right now no compression methods are supported. For more on Bloom filter compression, see Michael Mitzenmacher's "Compressed Bloom Filters", https://www.eecs.harvard.edu/~michaelm/NEWWORK/postscripts/cbf2.pdf
jbapple
force-pushed
the
bloom-compress
branch
from
8d97e9b
to
c421276
Compare
|
Thanks @jbapple! I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now no compression methods are supported. For more on Bloom
filter compression, see Michael Mitzenmacher's "Compressed Bloom
Filters",
https://www.eecs.harvard.edu/~michaelm/NEWWORK/postscripts/cbf2.pdf