PARQUET-2215: [Format] Document overflow handling in DELTA_BINARY_PACKED #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rok |
rok
reviewed
Nov 23, 2022
Encodings.md
Outdated
Comment on lines
222
to
225
| Subtractions in steps 1) and 2) may incur signed arithmetic overflow. Overflow | ||
| should be allowed and handled as wrapping around in 2's complement notation. | ||
| This may require explicit care in some programming languages (for example by | ||
| doing all arithmetic in the unsigned domain). |
There was a problem hiding this comment.
Perhaps we should note that this produces the correct result on decoding?
There was a problem hiding this comment.
It is, but maybe if it were less subtle it would save readers having to reason through it?
There was a problem hiding this comment.
Ok, I elaborated a bit. Does it help?
|
@ksuarez1423 @wjones127 Would you like to take a look at the wording? |
gszadovszky
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also word-wrapping for better source readability and editability.