Misspells, White Spaces, add some clarifications #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| written first, before the data pages of the column chunk. | ||
|
|
||
| Dictionary page format: the entries in the dictionary - in dictionary order - using the [plain](#PLAIN) encoding. | ||
| Dictionary page format: the entries in the dictionary - in dictionary order - using the [plain](#PLAIN) enncoding. |
|
One nit. |
|
I think this is still worth doing, so I created PARQUET-1031 for it. @Mistobaan - Do you want to pick this up again? |
lekv
pushed a commit
to lekv/parquet-format
that referenced
this pull request
Jul 31, 2017
This patch adds `PARQUET_BUILD_TESTS` and `PARQUET_BUILD_EXECUTABLES` options. For example: ``` $ cmake -DPARQUET_BUILD_TESTS=OFF -DPARQUET_BUILD_EXECUTABLES=OFF .. ``` This will accelerate builds in 3rd-party use. When the library is more mature we can set the default for `PARQUET_BUILD_TESTS` to `OFF` Author: Wes McKinney <wes@cloudera.com> Closes apache#39 from wesm/PARQUET-448 and squashes the following commits: 6bf6a54 [Wes McKinney] Add cmake options to not build tests and/or executables
asfgit
pushed a commit
that referenced
this pull request
Oct 11, 2017
rebased pull request #39, fixed minor spelling mistake and the travis-ci URLs (which also pointed to the Parquet/parquet-format one). @Mistobaan please let me know if you would like to reclaim the original pull request. Author: Fabrizio (Misto) Milo <mistobaan@gmail.com> Author: Anna Szonyi <szonyi@cloudera.com> Closes #59 from commanderofthegrey/parquet-1031 and squashes the following commits: e61c3b5 [Anna Szonyi] add back uncompressed_page_size 1cb8163 [Anna Szonyi] PARQUET-1031: Fix spelling errors, whitespace, GitHub urls 67f0064 [Fabrizio (Misto) Milo] explicit that the length has no sign e901ded [Fabrizio (Misto) Milo] fix misspells ceda268 [Fabrizio (Misto) Milo] remove spaces e1f9479 [Fabrizio (Misto) Milo] fix mispell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.