Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PARQUET-322 Document ENUM as a logical type. #54

Closed
wants to merge 1 commit into from
Closed

PARQUET-322 Document ENUM as a logical type. #54

wants to merge 1 commit into from

Conversation

jkukul
Copy link
Contributor

@jkukul jkukul commented May 6, 2017

No description provided.

rdblue
rdblue reviewed May 9, 2017
View reviewed changes
LogicalTypes.md Outdated
`ENUM` annotates the binary primitive type and indicates that the value
was converted from an enumarated type in another data model (e.g. Thrift, Avro, Protobuf).
Applications using a data model lacking a native enum type should interpret `ENUM`
annotated field as a UTF-8 encoded string.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should the ENUM type's sort order be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I update the commit with the line below.

lekv
lekv requested changes May 10, 2017
View reviewed changes
LogicalTypes.md Outdated
### ENUM

`ENUM` annotates the binary primitive type and indicates that the value
was converted from an enumarated type in another data model (e.g. Thrift, Avro, Protobuf).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: enumerated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) Fixed.

@lekv
Copy link
Contributor

lekv commented Jun 15, 2017

LGTM. @rdblue - Do you have more comments?

@rdblue
Copy link
Contributor

rdblue commented Jul 29, 2017

This looks fine to me. @julienledem, any comment?

@asfgit asfgit closed this in f59258a Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdblue rdblue rdblue left review comments

@lekv lekv lekv requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jkukul @lekv @rdblue