PARQUET-2219: ParquetFileReader skips empty row group #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parquet specs does not forbid empty row group and some implementations are able to generate files with empty row group. The commit aims to make ParquetFileReader robust by skipping empty row group while reading.
|
@gszadovszky @ggershinsky @shangxinli @sunchao Could you please take a look when you have time? cc @emkornfield |
gszadovszky
requested changes
Jan 9, 2023
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestParquetReaderEmptyBlock.java
Show resolved
Hide resolved
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
Show resolved
Hide resolved
|
@gszadovszky Nice to see you are back! |
- add test file for empty blocks next to each other
Thanks for your review @gszadovszky ! I have addressed all of your comments. Please take a look again. |
shangxinli
reviewed
Jan 10, 2023
| try { | ||
| rowGroup = internalReadRowGroup(currentBlock); | ||
| } catch (ParquetEmptyBlockException e) { | ||
| LOG.warn("Read empty block at index {}", currentBlock); |
There was a problem hiding this comment.
Any way to add file path?
There was a problem hiding this comment.
Added the file path to the log. Please take a look again. Thanks!
shangxinli
reviewed
Jan 10, 2023
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
Outdated
Show resolved
Hide resolved
@shangxinli, I wouldn't say I'm back, unfortunately. I'm a bit closer to Parquet at Dremio but actually not working on it. We'll see if I will have some spare time for it. :) |
gszadovszky
approved these changes
Jan 10, 2023
shangxinli
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
My PR addresses the PARQUET-2219.
Tests
My PR adds the following unit test to read parquet file with empty row group:
Two test parquet files are created by C++ parquet writer from Apache Arrow.
Commits
The parquet specs does not forbid empty row group and some implementations are able to generate files with empty row group. The commit aims to make ParquetFileReader robust by skipping empty row group while reading.