Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2446: ProtoParquetWriter support dynamic message #1295

Merged

Conversation

KingNF
Copy link
Contributor

@KingNF KingNF commented Mar 8, 2024

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "ProtoParquetWriter doesn't Support DynamicMessage"

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:this change is simple and only affects the ProtoParquetWriter Builder function

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@KingNF KingNF force-pushed the proto-Parquet-writer-support-dynamicMessage branch from 64932d5 to 60c6d70 Compare March 8, 2024 05:10
@KingNF
Copy link
Contributor Author

KingNF commented Mar 11, 2024

Hello everyone, Can someone please check this PR when you are free? Many thanks!

@wgtmac
Copy link
Member

wgtmac commented Mar 11, 2024

Thanks for the fix! Could you add a test case please?

@KingNF
Copy link
Contributor Author

KingNF commented Mar 12, 2024

Thanks for your time, @wgtmac. have added a test case.

@wgtmac wgtmac merged commit c28e4a6 into apache:master Mar 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants