PARQUET-290: Add data model to Avro reader builder #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM +1 |
rdblue
force-pushed
the
PARQUET-290-data-model-builder
branch
from
294e69f
to
d257a2c
Compare
|
|
||
| @Override | ||
| protected ReadSupport<T> getReadSupport() { | ||
| if (isReflect) { |
There was a problem hiding this comment.
isReflect is always true. Shouldn't it be false by default?
The else below is unusable because of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently includes #203, which will be removed when it is merged.