PARQUET-380: Fix build when using thrift 0.9.0. #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
force-pushed
the
PARQUET-380-fix-thrift-0.9.0
branch
2 times, most recently
from
aa82aa4
to
ddf1aed
Compare
rdblue
force-pushed
the
PARQUET-380-fix-thrift-0.9.0
branch
from
ddf1aed
to
ed78866
Compare
rdblue
force-pushed
the
PARQUET-380-fix-thrift-0.9.0
branch
from
ed78866
to
a74a377
Compare
|
Looks like other people are hitting this as PARQUET-391. I've rebased this on master so we can get it in. Could you take a look @julienledem? |
| @@ -39,6 +39,10 @@ | |||
| </repository> | |||
| </repositories> | |||
|
|
|||
| <properties> | |||
| <slf4j.version>1.5.8</slf4j.version> | |||
| </properties> | |||
There was a problem hiding this comment.
this should be in the root pom.
|
one small comment otherwise. LGTM |
rdblue
force-pushed
the
PARQUET-380-fix-thrift-0.9.0
branch
from
a74a377
to
4bc3492
Compare
This adds the correct version of libthrift as a dependency for parquet-cascading and parquet-scrooge, which overrides the 0.7.0 dependency that elephantbird uses.
rdblue
force-pushed
the
PARQUET-380-fix-thrift-0.9.0
branch
from
4bc3492
to
cbf0d84
Compare
piyushnarang
pushed a commit
to piyushnarang/parquet-mr
that referenced
this pull request
Jun 15, 2016
This adds the correct version of libthrift as a dependency for parquet-cascading and parquet-scrooge, which overrides the 0.7.0 dependency that elephantbird uses. Author: Ryan Blue <blue@apache.org> Closes apache#276 from rdblue/PARQUET-380-fix-thrift-0.9.0 and squashes the following commits: cbf0d84 [Ryan Blue] PARQUET-380: Fix build when using thrift 0.9.0.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jul 13, 2016
This adds the correct version of libthrift as a dependency for parquet-cascading and parquet-scrooge, which overrides the 0.7.0 dependency that elephantbird uses. Author: Ryan Blue <blue@apache.org> Closes apache#276 from rdblue/PARQUET-380-fix-thrift-0.9.0 and squashes the following commits: cbf0d84 [Ryan Blue] PARQUET-380: Fix build when using thrift 0.9.0.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
This adds the correct version of libthrift as a dependency for parquet-cascading and parquet-scrooge, which overrides the 0.7.0 dependency that elephantbird uses. Author: Ryan Blue <blue@apache.org> Closes apache#276 from rdblue/PARQUET-380-fix-thrift-0.9.0 and squashes the following commits: cbf0d84 [Ryan Blue] PARQUET-380: Fix build when using thrift 0.9.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the correct version of libthrift as a dependency for
parquet-cascading and parquet-scrooge, which overrides the 0.7.0
dependency that elephantbird uses.