PARQUET-352: Add object model property to file footers. #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WriteSupport now has a getName getter method that is added to the footer if it returns a non-null string as writer.model.name. This is intended to help identify files written by object models incorrectly.
| */ | ||
| public String getName() { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
we could also add a constructor parameter. (and keep the original default constructor for compatibility)
There was a problem hiding this comment.
and mark the old one deprecated
There was a problem hiding this comment.
My reasoning is that using the constructor requires updates in a lot more places and it would be easier to overlook cases that need it.
|
I made a comment about passing this to the constructor instead, but this looks good to me either way. |
|
Thanks for reviewing, Julien! |
piyushnarang
pushed a commit
to piyushnarang/parquet-mr
that referenced
this pull request
Jun 15, 2016
WriteSupport now has a getName getter method that is added to the footer if it returns a non-null string as writer.model.name. This is intended to help identify files written by object models incorrectly. Author: Ryan Blue <blue@apache.org> Closes apache#289 from rdblue/PARQUET-352-add-object-model-property and squashes the following commits: 23f8f67 [Ryan Blue] PARQUET-352: Add object model property to file footers.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jul 13, 2016
WriteSupport now has a getName getter method that is added to the footer if it returns a non-null string as writer.model.name. This is intended to help identify files written by object models incorrectly. Author: Ryan Blue <blue@apache.org> Closes apache#289 from rdblue/PARQUET-352-add-object-model-property and squashes the following commits: 23f8f67 [Ryan Blue] PARQUET-352: Add object model property to file footers.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
WriteSupport now has a getName getter method that is added to the footer if it returns a non-null string as writer.model.name. This is intended to help identify files written by object models incorrectly. Author: Ryan Blue <blue@apache.org> Closes apache#289 from rdblue/PARQUET-352-add-object-model-property and squashes the following commits: 23f8f67 [Ryan Blue] PARQUET-352: Add object model property to file footers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WriteSupport now has a getName getter method that is added to the footer
if it returns a non-null string as writer.model.name. This is intended
to help identify files written by object models incorrectly.