PARQUET-357: Parquet-thrift generates wrong schema for Thrift binary fields #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gszadovszky
requested changes
Dec 6, 2017
| @@ -163,6 +163,9 @@ private static ThriftField toThriftField(String name, Field field, ThriftField.R | |||
| break; | |||
| case STRING: | |||
| type = new StringType(); | |||
| if (field.getFieldMetaData() != null && field.getFieldMetaData().valueMetaData.isBinary()) { | |||
There was a problem hiding this comment.
I would suggest using local variables instead of testing a getter return to null and then invoke the same getter again.
| @@ -163,6 +163,9 @@ private static ThriftField toThriftField(String name, Field field, ThriftField.R | |||
| break; | |||
| case STRING: | |||
| type = new StringType(); | |||
| if (field.getFieldMetaData() != null && field.getFieldMetaData().valueMetaData.isBinary()) { | |||
| ((StringType) type).setBinary(true); | |||
There was a problem hiding this comment.
It would be more readable if a separate local variable would contain a StringType (so no casting would be needed) and then set the value of this variable to type.
gszadovszky
approved these changes
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.