PARQUET-1183: Add Avro builders using InputFile and OutputFile. #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbonofre, could you look at this and make sure it meets your needs? |
|
I am struggling with git, apologies for the extra work. |
|
@zivanfi, could you review this? It was requested for the next release. @wernerdaehn, I'll close the other issue when this is merged. Does this meet your needs? |
|
Yes, certainly. And my apologies again. I promise I will get better. |
|
No problem, thanks for contributing. |
zivanfi
approved these changes
Mar 1, 2018
|
Good catch, I'll mark them deprecated in the Avro API as well. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #446. I'm adding this PR because we want to get this into 1.10.0 and haven't heard back from that PR's author.