PARQUET-1440: Convert int32 or int64 decimal values to BigDecimals #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please open a JIRA about this issue and reference its number in PR title? Thanks! |
I did. Let me know if there's anything else I can do. |
zivanfi
changed the title
zivanfi
approved these changes
Oct 9, 2018
|
Merged, thanks! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests updates the
DecimalConverterto override theaddIntandaddLongmethods so it will return a BigDecimal with the proper scale when reading anint32orint64that is aDECIMALwith a specific scale.Without this override in place, the scale factor is ignored and the
int32 DECIMALvalues are displayed inaccurately