Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PARQUET-1717] Convert i16 thrift to INT16 logical type instead #706

Merged
merged 2 commits into from Dec 12, 2019

Conversation

ebrard
Copy link
Contributor

@ebrard ebrard commented Dec 11, 2019

Make sure you have checked all steps below.

Jira

Tests

  • My PR does not need testing for this extremely good reason: No new functions were added

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@nandorKollar
Copy link
Contributor

Thanks for taking a look at this! Could you please also add a test case too?

@ebrard
Copy link
Contributor Author

ebrard commented Dec 11, 2019

Will do.

Add unit test for i16 thrift type
@ebrard
Copy link
Contributor Author

ebrard commented Dec 11, 2019

@nandorKollar I added a simple test for this specific conversion, I hope that's the right approach

Copy link
Contributor

@nandorKollar nandorKollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nandorKollar nandorKollar merged commit 4ca29c7 into apache:master Dec 12, 2019
shangxinli pushed a commit to shangxinli/parquet-mr that referenced this pull request Dec 16, 2019
…he#706)

* [PARQUET-1717] Convert i16 thrift to INT16 logical type instead of INT32 primitive

* [Parquet-1717] Add unit test
Add unit test for i16 thrift type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants