Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-1729: Avoid AutoBoxing in EncodingStats #717

Merged
merged 4 commits into from Jan 10, 2020

Conversation

belugabehr
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@belugabehr
Copy link
Contributor Author

Will probably conflict with #711 but should be easy to resolve.

@Fokko
Copy link
Contributor

Fokko commented Jan 2, 2020

@belugabehr can you resolve the conflicts? Thanks!

@belugabehr
Copy link
Contributor Author

@Fokko Done. Thank you, so much, for yet another review!

@Fokko
Copy link
Contributor

Fokko commented Jan 9, 2020

@belugabehr can you resolve the conflicts? Thanks!

@Fokko Fokko merged commit d85a8f5 into apache:master Jan 10, 2020
shangxinli pushed a commit to shangxinli/parquet-mr that referenced this pull request Mar 1, 2020
* PARQUET-1729: Avoid AutoBoxing in EncodingStats

* Updated unit tests to more properly check stats value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants