Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PARQUET-1802: Use job ClassLoader to load CompressionCodec class #760

Merged
merged 1 commit into from Feb 24, 2020
Merged

PARQUET-1802: Use job ClassLoader to load CompressionCodec class #760

merged 1 commit into from Feb 24, 2020

Conversation

chtyim
Copy link
Member

@chtyim chtyim commented Feb 19, 2020 •
edited

Make sure you have checked all steps below.

Jira

Tests

  • My PR does not need testing for this extremely good reason:
    • The change is trivial
    • It preserves the existing behavior

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@chtyim
PARQUET-1802: Use job ClassLoader to load CompressionCodec class
cddcea2 
The MR job might be having a different ClassLoader then
the defining ClassLoader of the CodecFactory class.
A CompressionCodec class that is not loadable via the
CodecFactory ClassLoader might be loadable through the
job ClassLoader.
@gszadovszky gszadovszky merged commit 583063b into apache:master Feb 24, 2020
shangxinli pushed a commit to shangxinli/parquet-mr that referenced this pull request Mar 1, 2020
@chtyim @shangxinli
PARQUET-1802: Use job ClassLoader to load CompressionCodec class (apa…
47dda3a 
…che#760)

The MR job might be having a different ClassLoader then
the defining ClassLoader of the CodecFactory class.
A CompressionCodec class that is not loadable via the
CodecFactory ClassLoader might be loadable through the
job ClassLoader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

@gszadovszky gszadovszky gszadovszky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@chtyim @Fokko @gszadovszky