Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-1886 CompressionCodec Provider-aware Compression Codec Lookup… #803

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XinDongSh
Copy link

… for parquet-mr

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@xhochy
Copy link
Member

xhochy commented Sep 21, 2020

Has there been a spec discussion about this on the mailing list?

@xhochy
Copy link
Member

xhochy commented Sep 21, 2020

Just to clarify: This enables overloading of the compression implementation but not adding new codecs?

@winningsix
Copy link

@xhochy It's overloading built-in compression implementation. And it's retrieving data from footer without introducing new spec info. Do you think we need to add it as part of spec?

@winningsix
Copy link

Connect to apache/arrow#8229

@shangxinli
Copy link
Contributor

shangxinli commented Apr 22, 2021

Thanks for working on it @XinDongIntel! Do you want to come to next week's Parquet Sync meeting to discuss? I know it was discussed earlier but now since we started working on new release, I think we can revisit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants