-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARROW-17904] add flatten data files with checksums on datapage v1 #29
Conversation
This will be used in apache/arrow#14351 |
I'm not sure I understand. Is there one file or two files with corrupt CRCs? |
Lets draw some pictures here:
And each page has |
Thanks @mapleFU , can you add that information to https://github.com/apache/parquet-testing/blob/master/data/README.md ? |
I've upload a basic description. But perhaps I'm not able to written a good document, so welcome to edit it directly. @pitrou |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mapleFU . This looks good to me.
Here I add 3 files for checking checksums, there schema are all:
And there contents are equal:
The code is borrow and modified from
parquet-mr
'sTestDataPageV1Checksums
, because seems that only parquet-mr implements crc on data page v1. Each file has two columns, and each column has two pages, the size of each page would tried to be 10KB.And: