Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new assertion for isFill #88

Closed
wants to merge 2 commits into from
Closed

Add a new assertion for isFill #88

wants to merge 2 commits into from

Conversation

Deee92
Copy link

@Deee92 Deee92 commented Oct 20, 2020

Hello,

I noticed with mutation testing that the behavior of org.apache.pdfbox.pdmodel.graphics.state.RenderingMode.isFill() is not specified.
If the body of isFill() is replaced with return true; or return false;, no test fails.

Here is a test case that specifies it with a new assertion.

@Test
public void testIsFill()
{
    // Arrange
    final RenderingMode objectUnderTest = RenderingMode.FILL;

    // Act
    final boolean retval = objectUnderTest.isFill();

    // Assert result
    Assert.assertEquals(true, retval);
}

What do you think?

Thanks!

@THausherr
Copy link
Contributor

You're right, and you're welcome. We're always looking to improve our test coverage, thanks.

@asfgit asfgit closed this in a8fbfec Oct 21, 2020
asfgit pushed a commit that referenced this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants