Add commands to apply and check codestyle #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
requested review from
jrudolph,
gmethvin,
He-Pin,
nvollmar,
seglo and
pjfanning
mdedetrich
commented
Jul 31, 2023
| @@ -124,12 +129,8 @@ lazy val `pekko-connectors` = project | |||
| crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465 | |||
| ) | |||
|
|
|||
| TaskKey[Unit]("verifyCodeFmt") := { | |||
There was a problem hiding this comment.
I have opted to replace this because the current style is overcomplicated especially when compared to addCommandAlias. This style made more sense in the past when we weren't checking that code was formatted on PR but this is no longer the case
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be seen from #205 (comment) users unfamiliar to the codebase are having issues both checking/applying scalafmt and javafmt to the codebase