Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTP: Add a setting to enable automatic server encoding detection #221

Merged
merged 1 commit into from Aug 14, 2023
Merged

FTP: Add a setting to enable automatic server encoding detection #221

merged 1 commit into from Aug 14, 2023

Conversation

TheDeadOne
Copy link
Contributor

Resolves #216 by adding a method to FtpSettings and FtpsSettings to enable or disable automatic server encoding detection.

pjfanning
pjfanning approved these changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks

I'd like to leave it open to see if other Pekko community members comment. I think this is safe for 1.0.0.

@pjfanning pjfanning added the release note should be mentioned in release notes label Aug 12, 2023
@pjfanning pjfanning added this to the 1.0.0 milestone Aug 12, 2023
mdedetrich
mdedetrich approved these changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 3f586ac into apache:main Aug 14, 2023
49 of 50 checks passed
@pjfanning
Copy link
Contributor

Thanks - merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdedetrich mdedetrich mdedetrich approved these changes

@pjfanning pjfanning pjfanning approved these changes

@He-Pin He-Pin Awaiting requested review from He-Pin

Assignees
No one assigned
Labels
release note should be mentioned in release notes
Projects
No open projects
Pekko Connectors v1.0.0 release
Status: Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

FTP: Server encoding detection
3 participants
@TheDeadOne @pjfanning @mdedetrich