Accept any materializer type param for S3's chunkUploadSink #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
requested review from
jrudolph,
gmethvin,
He-Pin,
nvollmar,
seglo and
pjfanning
pjfanning
reviewed
Nov 12, 2023
|
Sure |
|
@pjfanning #278 has been approved |
That PR is merged. Could you rebase this? |
mdedetrich
force-pushed
the
accept-any-type-param-for-chunk-upload-sink
branch
from
18fc293
to
f506c56
Compare
|
@pjfanning The relevant tests passed (including MiMa check) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I originally added this functionality I mistakingly hardcoded the type parameter to
NotUsedrather than just using_(which means don't care). While this may initially seem like a non-issue, a problem eventuates if you happen to use aSinkthat materializes a value that is contained within aFuturei.e.Sink[(UploadPartResponse, immutable.Iterable[C]), Future[Done]]. Such sinks are quite common and there is no way to get a value outside of aFutureaside from blocking (which you should never do in production code) in order to satisfychunkUploadSink: Sink[(UploadPartResponse, immutable.Iterable[C]), NotUsed].Note that since
chunkUploadSinkultimately ends up getting used in.alsoTowhos materializer type argument param is also_(see https://github.com/apache/incubator-pekko/blob/1b1f57224b409c8b2cbd5267ace814439e97d3ea/stream/src/main/scala/org/apache/pekko/stream/scaladsl/Flow.scala#L3464) and the fact that we are only dealing with type parameters which get erased at runtime means that this change is completely safe for the 1.0.x series (in fact it shouldn't even generate any bytecode difference either way, all this does is make scalac satisfy code where the materializer type param is notNotUsed)