Kinesis: fix maxBytesPerSecond throttling #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
lgtm. If we wan't to be strict this should land in 1.1.0 since this is a behaviour change but afaict the current functionality appears to be broken so this can be an exception
@jtjeferreira Can you confirm?
yes the current functionality is broken |
|
Merging - as it is a bug fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kinesis throttling is not being respected because the function
getPayloadByteSizeis incorrect.request.data.asByteBuffer.position()can return 0The ticket was originally reported in akka/alpakka#2871 and I did the fix in the akka repository. AFAICT I can use the same code as long as I am the author...