-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update java-client to 3.5.2 #400
Conversation
7bcaf01
to
d450334
Compare
I has checked website of couchHbase, 2.x is deprecated. |
The problem is the build breaks. Some couchbase classes have moved to new jars or have been removed. I couldn't find good migration notes for couchbase 3. |
https://docs.couchbase.com/java-sdk/current/project-docs/migrating-sdk-code-to-3.n.html#installation-and-configuration is the official guide. If anyone has the time and interest to take this on, it would be great. |
@laglangyue Would you like to give this a try, thanks. |
yes, I will take some time to learn the datasource and fix it |
I have read the official website documentation, and there are some changes to client3 and client2
And they provided scala sdk, my suggestion is to implement a connector based on scala sdk. @pjfanning @He-Pin how about using scala-sdk? |
I am not against trying the new scala SDK |
@laglangyue Nice, but I just back my hometown will not be able to review it on any soon, and happy Spring Festival |
Sorry, I retract my previous viewpoint. Couchbase's scala sdk does not support scala3. I wanted to submit a PR(use scala3), but found out that their project is not SBT. Scala on Maven is very painful, so I gave up on providing them with a PR. |
Indeed, Scala with Maven is painful especially ofr libraries which is why I don't recommend maven for people that use Scala. Afaik maven fundamentally doesn't even have a concept of matrix's for builds, so the only proper way to cross publish is to do hacks like modifying a hardcoded scala version in pom.xml. Using the java client may be a better option, Also now is the time to do significant changes such as upgrading major versions of underlying libraries (in this case couchbase sdk). Pekko connectors doesn't subscribe to semver and for 1.1.x series of pekko connectors the goal specifically is to use the latest versions of all of the underlying sdk's, spi's etc etc |
d450334
to
f2e2159
Compare
I ended my the Spring Festival vacation and back today.It's a bit long,I will complete this PR. Report some progress to community. Due to the lack of a trait Document[T, R] {
def id: String
// json / object
def doc: T
// getResult / mutationResult etc
def result: R
} Code had pushed to my repo, welcome any suggestions |
About this PR
📦 Updates com.couchbase.client:java-client from
2.7.23
to3.5.2
⚠Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: