Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Couchbase3 #624

Merged
merged 21 commits into from
May 6, 2024
Merged

Support Couchbase3 #624

merged 21 commits into from
May 6, 2024

Conversation

laglangyue
Copy link
Contributor

@laglangyue laglangyue commented Apr 21, 2024

motivation

relates to #623
support couchbase3
should be after from dropping couchbase2

test

have some test, not finished

docs

not finished

@laglangyue laglangyue marked this pull request as draft April 21, 2024 12:02
@pjfanning
Copy link
Contributor

thanks - looks like a reasonable approach

there are some issues

  • code doesn't compile
[error] /home/runner/work/pekko-connectors/pekko-connectors/couchbase3/src/main/scala/org/apache/pekko/stream/connectors/couchbase3/scaladsl/CouchbaseSource.scala:92:49: too many arguments (found 2, expected 1) for method query: (x$1: com.couchbase.client.java.query.N1qlQuery): rx.Observable[com.couchbase.client.java.query.AsyncN1qlQueryResult]
[error]       .completionStage(cluster.query(statement, options))
[error]                                                 ^
[error] /home/runner/work/pekko-connectors/pekko-connectors/couchbase3/src/main/scala/org/apache/pekko/stream/connectors/couchbase3/scaladsl/CouchbaseSource.scala:110:32: value analyticsQuery is not a member of com.couchbase.client.java.AsyncCluster
[error]       .completionStage(cluster.analyticsQuery(statement, options))
[error]     
  • scalafmt issues
  • missing Apache header on Example.scala

@laglangyue laglangyue marked this pull request as ready for review April 23, 2024 06:15
@laglangyue
Copy link
Contributor Author

@pjfanning could you open the ci action in free time,I have tested it locally today. I would not add more api for dsl. maybe a doc pr plan was described in issues

@laglangyue
Copy link
Contributor Author

@pjfanning PTAL, just a FTP flaky test failed. I have found a new job, so I currently do not have time to fix this issue of FTP.
I create a issue about FTP to record it, maybe in two weeks, I will do some deep digging for ftp
#627

@laglangyue
Copy link
Contributor Author

Sorry, my response was a bit late. I changed my job and was very busy. The new job is not related to Pekko, so I can only participate in Pekko during my vacation at the moment.
I will process the review comments as soon as possible

@pjfanning
Copy link
Contributor

Sorry, my response was a bit late. I changed my job and was very busy. The new job is not related to Pekko, so I can only participate in Pekko during my vacation at the moment. I will process the review comments as soon as possible

No Problem at all. Take your time. Thanks for your diligent work.

@laglangyue
Copy link
Contributor Author

resolve conflict for build.sbt and rebase

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 2ce1866 into apache:main May 6, 2024
51 checks passed
@pjfanning
Copy link
Contributor

I've merged this but left #623 open because we'll need at least some doc changes to reflect the new cloudbase3 connector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants