-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Couchbase3 #624
Support Couchbase3 #624
Conversation
thanks - looks like a reasonable approach there are some issues
|
@pjfanning could you open the ci action in free time,I have tested it locally today. I would not add more api for dsl. maybe a doc pr plan was described in issues |
@pjfanning PTAL, just a FTP flaky test failed. I have found a new job, so I currently do not have time to fix this issue of FTP. |
couchbase3/src/test/scala/org/apache/pekko/stream/connectors/couchbase3/CouchbaseSupport.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/org/apache/pekko/stream/connectors/couchbase3/scaladsl/CouchbaseSource.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/org/apache/pekko/stream/connectors/couchbase3/scaladsl/CouchbaseSource.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/org/apache/pekko/stream/connectors/couchbase3/scaladsl/CouchbaseSource.scala
Show resolved
Hide resolved
Sorry, my response was a bit late. I changed my job and was very busy. The new job is not related to Pekko, so I can only participate in Pekko during my vacation at the moment. |
No Problem at all. Take your time. Thanks for your diligent work. |
resolve conflict for build.sbt and rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I've merged this but left #623 open because we'll need at least some doc changes to reflect the new cloudbase3 connector. |
motivation
relates to #623
support couchbase3
should be after from dropping couchbase2
test
have some test, not finished
docs
not finished