Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pekko-connectors-bom #633

Merged
merged 2 commits into from
Apr 27, 2024
Merged

add pekko-connectors-bom #633

merged 2 commits into from
Apr 27, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Apr 26, 2024

Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks.

If we have a BOM that records all modules(more tha this), it will be better, but it will come with higher maintenance costs.

build.sbt Show resolved Hide resolved
@pjfanning
Copy link
Contributor Author

Looks good, Thanks.

If we have a BOM that records all modules(more tha this), it will be better, but it will come with higher maintenance costs.

I have https://github.com/pjfanning/pekko-libraries-bom. The SBT bill-of-materials plugin can only handle projects in same repo. My project is easier to maintain if the main pekko repos have BOMs that I can more easily aggregate.

@Roiocam
Copy link
Member

Roiocam commented Apr 27, 2024

My project is easier to maintain if the main pekko repos have BOMs that I can more easily aggregate.

It sounds reasonable. Let's move forward.

@pjfanning pjfanning merged commit fd58991 into apache:main Apr 27, 2024
50 checks passed
@pjfanning pjfanning deleted the bom branch April 27, 2024 20:24
@pjfanning pjfanning added this to the 1.1.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants