Only pass SSE headers for multipart upload requests #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
requested review from
jrudolph,
gmethvin,
He-Pin,
nvollmar,
seglo and
pjfanning
mdedetrich
force-pushed
the
only-pass-sse-headers-for-multipart-upload
branch
from
73ca7b6
to
a071e8b
Compare
|
I have added this PR onto the 1.0.0 project because currently the Pekko S3 client is broken without this fix. |
He-Pin
reviewed
Apr 19, 2023
| .withHeader(sseCAlgorithmHeader, new EqualToPattern(sseCAlgorithmHeaderValue)) | ||
| .withHeader(sseCKeyHeader, new EqualToPattern(sseCKeyHeaderValue)) | ||
| .withHeader(sseCKeyHeaderMd5, new EqualToPattern(sseCKeyHeaderMd5Value)) | ||
| .withoutHeader(requestPayerHeader)) |
There was a problem hiding this comment.
new EqualToPattern(...) would looks better with EqualToPattern(...)
There was a problem hiding this comment.
I just followed the same style that is done in the rest of the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes akka/alpakka#2906, Alpakka created a regression whereby their latest Alpakka BSL release (4.0.0) has multipart upload broken.
According to S3 docs (see https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html#API_CompleteMultipartUpload_Examples), you are not allowed to have any other headers that is not SSE related.
I tested this on my companies S3 account and I can confirm that it passes.