Add bucketVersioningEnabled helper methods #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
requested review from
jrudolph,
gmethvin,
He-Pin,
nvollmar,
seglo and
pjfanning
pjfanning
reviewed
May 1, 2023
| @@ -194,6 +200,12 @@ final class BucketVersioning private (val status: Option[BucketVersioningStatus] | |||
| /** Java API */ | |||
| def getMfaDelete: java.util.Optional[MFAStatus] = mfaDelete.asJava | |||
|
|
|||
| /** Java API */ | |||
| def getBucketVersioningEnabled: Boolean = bucketVersioningEnabled | |||
There was a problem hiding this comment.
With Java APIs, it is more common to use 'is' instead of 'get' for the names of getters that return booleans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on from #84, one of the common usecases for bucket versioning is to figure out if its enabled/disabled and due to the current field being nested inside of an option with a custom ADT the helper methods are being added to trivialize the operation.
Note that a Java alias is being added since the rest of the models in S3 follow the
field/getFieldfor Scala/Java repsectively.