Uptake pekko jars, use pekko names in packages and configs

[pjfanning]

• relates to Uptake pekko jars and switch to pekko config names #21
• use pekko and pekko-http jars
• use pekko prefix in config names
• temporarily removed akka-http-cors in this repo because that lib does not yet support pekko - but soon will (reintroduce dependency on akka-http-cors (or pekko equivalent)  #22)
• some pekko renaming
• have left the build of the doc updates until later (to keep down size of this PR)

[jrudolph]

Great stuff!

• temporarily added akka-http-cors in this repo because that lib does not yet support pekko - but soon will

Isn't that a blocker for merging this PR for now? Feels wrong to add third-party code as part of such a big commit just to get everything working right now.

How about we just disable cors support for now to make this PR mergable (it's only used in four lines in the code) and then decide afterwards if we want to temporarily enable it again by importing the third-party project in its own PR or wait until the project itself has released something?

[jrudolph]

• temporarily added akka-http-cors in this repo because that lib does not yet support pekko - but soon will

Isn't that a blocker for merging this PR for now? Feels wrong to add third-party code as part of such a big commit just to get everything working right now.

If we would really want to add it to this project, we would have change its package name to avoid future problems for users which use both pekko-http-cors and pekko-grpc.

[pjfanning]

I guess I had the pekko version of akka-http-cors ready so it seemed easiest to use it but I can look at disabling cors support instead.

[mdedetrich]

Another option would be to wait a couple of weeks, the owner of akka-http-cors did say they are going to migrate over to pekko and since the akka-http-cors is pretty trivial there shouldn't be too much of a risk of it taking too long.

[pjfanning]

The cors code in pekko-grpc does look like it is non-trivial to rip out (and later add back) - so we might be best off waiting

[jrudolph]

The cors code in pekko-grpc does look like it is non-trivial to rip out (and later add back) - so we might be best off waiting

Was easy enough, I added it here: pjfanning#1. This might break something but it's only used in grpc-web which is less used than regular grpc support. I don't mind waiting for cors support, on the other hand, getting a snapshot version out which mostly works besides grpc-web/cors support might still be interesting.

[pjfanning]

I merged @jrudolph change. I'm happy to have this merged if the consensus is that we can look at adding back the CORS support in a few weeks.

[mdedetrich]

Fine with me, just make an issue for it so we don't forget

[pjfanning]

There is #22

[mdedetrich]

So I did a more comprehensive look at the PR and I noticed that @apidoc was being removed, is there a reason why?

If its because it didn't compile, you usually need to update the Paradox prefix, i.e. setting ApidocPlugin.autoImport.apidocRootPackage to org.apache.pekko should fix the problem.

[pjfanning]

I've tried out the apidoc changes but CI is struggling due to Jabba connectivity issues

[mdedetrich]

Hmm, the jabba issues seem completely unrelated, jabba is used in setup-scala github action just to download JDK. Let me see

[mdedetrich]

Yeah so everything related to JDK 11 is failing because of

      - name: Set up JDK 11
        uses: olafurpg/setup-scala@v13
        with:
          java-version: adopt@1.11

If we change this to setup-java instead of setup-scala (like we did with pekko) this should solve the problem, i.e.

      - name: Setup Java 11
        uses: actions/setup-java@v3
        with:
          distribution: temurin
          java-version: 11

[pjfanning]

Jabba will probably start working again. I can do a separate PR for setup-java switch. I can do that now.

[mdedetrich]

Jabba will probably start working again. I can do a separate PR for setup-java switch. I can do that now.

I think it makes sense to do it now, its a trivial PR and needs to be done anyways (setup-scala as we can see has problems).

[mdedetrich]

Okay I am going to approve this, tests are passing. I noticed some more cases where we are still using Akka in class/object names so feel free to update those before merging.

As mentioned before the only other thing that needs to be changed is to make the import style consistent with the Pekko akka projects, I can go ahead and do this after the PR is merged.