fix more issues with legacy Akka naming #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjfanning Apologies but my javafmt commit caused some merge conflicts on this PR but they are relatively minor. If you do a rebase on |
pjfanning
force-pushed
the
more-pekko-naming
branch
from
d7f291d
to
a6d8441
Compare
|
@mdedetrich I was aware that it would happen. I have fixed the merge conflicts now. |
|
Do you want this to be reviewed, you didn't assign any reviewers? |
|
I typically wait for a clean CI run before assigning reviewers |
|
@mdedetrich no hurry on merging this but I think it is safe to merge and that it doesn't have any effect (good or bad) on the scaladoc generation issue |
|
Noted, I will check it after I fix the pekko docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.