-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: explain the existence of extra-libs.zip #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
d8de5ef
to
9d047f0
Compare
Are we sure that will keep everyone happy? I have my doubts. Can we consider removing the zip and building it at test run time? |
@justinmclean is it enough to provide a readme for this |
I would like to avoid building it at build time because then we might not uncover the encoding issues. The whole point is to have an example that we know has been built correctly and then test that this works while testing/building. |
I'm happy to have the file but I'm not the one blocking the release |
You can leave it there but there is a chance some IPMC member might vote -1 as they consider it a binary file in a source release. It doesn't contain compiled code so I think it is OK - but you need to look inside it to find that out. |
There is no binary code contained in
If I understand correctly, the point of the |
No description provided.