Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: explain the existence of extra-libs.zip #239

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

jrudolph
Copy link
Contributor

No description provided.

@jrudolph jrudolph mentioned this pull request Jul 19, 2023
12 tasks
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jrudolph jrudolph merged commit aafcae9 into apache:main Jul 19, 2023
14 checks passed
@jrudolph jrudolph deleted the explain-extra-lib.zip branch July 19, 2023 08:21
@pjfanning
Copy link
Contributor

Are we sure that will keep everyone happy? I have my doubts. Can we consider removing the zip and building it at test run time?

@pjfanning
Copy link
Contributor

@justinmclean is it enough to provide a readme for this extra-libs.zip and why it is needed for unit testing? Or do we need to remove the file and come up with a way of having the test code make the zip when it is executing the test?

@jrudolph
Copy link
Contributor Author

I would like to avoid building it at build time because then we might not uncover the encoding issues. The whole point is to have an example that we know has been built correctly and then test that this works while testing/building.

@pjfanning
Copy link
Contributor

I'm happy to have the file but I'm not the one blocking the release

@justinmclean
Copy link
Member

You can leave it there but there is a chance some IPMC member might vote -1 as they consider it a binary file in a source release. It doesn't contain compiled code so I think it is OK - but you need to look inside it to find that out.

@mdedetrich
Copy link
Contributor

mdedetrich commented Jul 19, 2023

You can leave it there but there is a chance some IPMC member might vote -1 as they consider it a binary file in a source release. It doesn't contain compiled code so I think it is OK - but you need to look inside it to find that out.

There is no binary code contained in extra-spaces.zip. It contains a single file called i have späces.jar and that jar itself only contains metadata + a text file, i.e.

<@incubator-pekko-http/h/s/test>-<⎇ update-latest-pekko-sbt-paradox>-<*>-> unzip i\ have\ späces.jar 
Archive:  i have späces.jar
   creating: META-INF/
  inflating: META-INF/MANIFEST.MF    
  inflating: test-resource.txt   

If I understand correctly, the point of the i have späces.jar is to just test some peculiarity regarding non unicode characters when it comes to jar classpath searching, nothing inside of i have späces.jar is actually executed (which makes sense since it doesn't contain any .class binary data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants