-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename akka package to org.apache.pekko #34
Rename akka package to org.apache.pekko #34
Conversation
d9e8059
to
f9deacf
Compare
@jrudolph I have done most of the work in regards to the package name change however I am now encountering an issue where any test that uses If there is anything on the top of your head that comes to mind let me know, otherwise I will have another look at this later in the week. |
f9deacf
to
4f8adbf
Compare
The event filters rely on |
Thanks for finding this out, indeed the issue is that some configuration in pekko core has changed from If it is however only a few changes necessary to make tests pass I might decide just to do those, lets see. |
That should be easy enough, every setting that does not start with |
fc8a08c
to
8f29425
Compare
So good news, tests are finally passing. There are still a couple of things I need to double check, i.e. that the |
a5e413f
to
8f8448d
Compare
8f8448d
to
38af0a2
Compare
PR is now ready to review, check original post for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Will wait for @jrudolph , specifically for comments around |
Cool, will have a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I browsed through the changes with git diff
and tried to find significant changes. A few minor comments but mostly lgtm
The only significant to PekkoDependency
is the change of the default, isn't it? And that sounds somewhat reasonable for now (it might become a bit inefficient for development if we automatically choose a new nightly every day and invalidate sbt caches on our machines, but if that becomes a problem we could also fix on a certain version for the time being).
@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads, | |||
named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle. | |||
It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`" | |||
however they go to sleep state immediately, thus wasting the resources. | |||
@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was that deleted intentionally? (Does not matter a lot)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah damn, forgot to mention this. So basically I cannot get this to compile because beforehand due to some shadowing rules it was picking up akka.dispatch.forkjoin.ForkJoinPool
and when I tried changing this to a FQCN (i.e. java.util.concurrent.ForkJoinPool
) as part of this PR it didn't compile however I noticed that both for current Akka and Pekko before this PR change it doesn't even render on the website so I just removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe, just add a Github issue to revisit this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, can do, will do it after PR merge so I can point the issue to correct part of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case it is not clear, the @java
block would only show if Java
is selected in the nav bar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, indeed, no need to fix it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case it is not clear, the
@java
block would only show ifJava
is selected in the nav bar.
Ah I see, but yes I will make an issue on this
//#bindAndHandleSecure | ||
//#bindAndHandlePlain | ||
import akka.http.scaladsl.Http | ||
import org.apache.pekko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure of the imports and how they are referenced into the docs seems to have changed here, was that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if you check the rendered docs with sbt paradox
you can see why I need to change the imports statements.
* Copyright (C) 2019-2022 Lightbend Inc. <https://www.lightbend.com> | ||
*/ | ||
|
||
package akka.http.javadsl.model; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a bunch of those files, the changes seem to be big enough that git does not detect the move any more, I guess not a big problem in practice, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For git diff
it seems adding the parameter -M1
works (consider renamed when only 10% of the file are the same, instead of default 50%).
For git blame
adding -C
helps to get the original commits.
Yes this is correct, I actually want to make an issue on this because my current impressions is this part of the build seems quite over-engineered but lets talk about it in the future issue I am talking about. |
Okay so I am going to go ahead and merge this, will also make an issue regarding #34 (comment) |
Issue regarding removed text created at #42 |
This PR renames the
akka
package toorg.apache.pekko
, as with the equivalent pekko core PR its recommended to checkout the branch and view the changes in a local git diff viewer since github UI does a bad job of rendering large diffs.Resolves: #21
Notable changes
private[akka]
, it wasn't possible to only change the pekko-http packages on a granular level. The PR also updates dependency resolution so it brings in the latest pekko snapshot that has been published into the Apache Nexus snapshots repo. Doing this involved making quite a few changes toAkkaBuild
(which is now calledPekkoBuild
), this part of the code handles automatically bringing in latest snapshot from a repository. @jrudolph Maybe you want to look into this so there isn't anything fishyakka.
topekko.
. A good example of this isakka.actor
which was changed topekko.actor
(sincepekko.actor
is not defined in pekko-http, its defined in pekko-core).akka
. Examples of this areH2SpecIntegrationSpec
andDontLeakActorsOnFailingConnectionSpecs
. This splitting of configuration will be reverted when I make a PR to also updated all of the pekko-http configurationsimport
statements are idiomatic (like with equivalent pekko core PR, for scala sources we doimport org.apache.pekko
and then after we do the variousimport pekko...
)