Rename akka package to org.apache.pekko #34

mdedetrich · 2023-02-05T10:12:14Z

This PR renames the akka package to org.apache.pekko, as with the equivalent pekko core PR its recommended to checkout the branch and view the changes in a local git diff viewer since github UI does a bad job of rendering large diffs.

Resolves: #21

Notable changes

Due to pekko-http using private[akka], it wasn't possible to only change the pekko-http packages on a granular level. The PR also updates dependency resolution so it brings in the latest pekko snapshot that has been published into the Apache Nexus snapshots repo. Doing this involved making quite a few changes to AkkaBuild (which is now called PekkoBuild), this part of the code handles automatically bringing in latest snapshot from a repository. @jrudolph Maybe you want to look into this so there isn't anything fishy
In general I only tried to do changes to package names and not configurations. There were however some exceptions, i.e. since pekko-http references configurations in pekko, some typesafe configs had to be changed from akka. to pekko.. A good example of this is akka.actor which was changed to pekko.actor (since pekko.actor is not defined in pekko-http, its defined in pekko-core).
- Ontop of this, some configurations also had to be split up because they were generally grouped under akka. Examples of this are H2SpecIntegrationSpec and DontLeakActorsOnFailingConnectionSpecs. This splitting of configuration will be reverted when I make a PR to also updated all of the pekko-http configurations
Paradox docs have also been updated for any references to packages and manually screened multiple times. I took care so that the import statements are idiomatic (like with equivalent pekko core PR, for scala sources we do import org.apache.pekko and then after we do the various import pekko...)

mdedetrich · 2023-02-06T10:12:05Z

@jrudolph I have done most of the work in regards to the package name change however I am now encountering an issue where any test that uses org.apache.pekko.testkit.EventFilter along with org.apache.pekko.testkit.TestEvent.intercept is failing. I have dune a cursory look through the code and couldn't find anything that would hint as to why its not working (i.e. I can't find any kind of hardcoded checking for the akka package).

If there is anything on the top of your head that comes to mind let me know, otherwise I will have another look at this later in the week.

jrudolph · 2023-02-06T11:17:53Z

If there is anything on the top of your head that comes to mind let me know, otherwise I will have another look at this later in the week.

The event filters rely on pekko.loggers being set correctly, but settings have not yet been changed to use the pekko prefix yet. In this case, the problem is in AkkaSpecWithMaterializer.

mdedetrich · 2023-02-06T11:22:26Z

Thanks for finding this out, indeed the issue is that some configuration in pekko core has changed from akka to pekko. Although its possible to find which specific typesafe config settings refer specifically to the parent pekko core, I think it will be easier/safer/clearer to also do all of the configuration changes in a separate commit in this PR.

If it is however only a few changes necessary to make tests pass I might decide just to do those, lets see.

jrudolph · 2023-02-06T11:28:38Z

Although its possible to find which specific typesafe config settings refer specifically to the parent pekko core

That should be easy enough, every setting that does not start with akka.http would be referring to a core setting.

mdedetrich · 2023-02-06T13:23:19Z

So good news, tests are finally passing. There are still a couple of things I need to double check, i.e. that the import statements in paradox are nicely formatted and some tests seem to produce a large amount of logs (which could indicate that the log silencing isn't working in some cases but it can also be the case that it was like this originally).

mdedetrich · 2023-02-13T10:34:59Z

PR is now ready to review, check original post for details.

pjfanning

lgtm

mdedetrich · 2023-02-13T11:09:43Z

Will wait for @jrudolph , specifically for comments around AkkaBuild/PekkoBuild.

jrudolph · 2023-02-14T09:21:17Z

Cool, will have a look now.

jrudolph

I browsed through the changes with git diff and tried to find significant changes. A few minor comments but mostly lgtm

The only significant to PekkoDependency is the change of the default, isn't it? And that sounds somewhat reasonable for now (it might become a bit inefficient for development if we automatically choose a new nightly every day and invalidate sbt caches on our machines, but if that becomes a problem we could also fix on a certain version for the time being).

jrudolph · 2023-02-14T09:38:51Z

docs/src/main/paradox/handling-blocking-operations-in-pekko-http-routes.md

@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads,
 named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle. 
 It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`" 
 however they go to sleep state immediately, thus wasting the resources.
-@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]


Was that deleted intentionally? (Does not matter a lot)

Ah damn, forgot to mention this. So basically I cannot get this to compile because beforehand due to some shadowing rules it was picking up akka.dispatch.forkjoin.ForkJoinPool and when I tried changing this to a FQCN (i.e. java.util.concurrent.ForkJoinPool) as part of this PR it didn't compile however I noticed that both for current Akka and Pekko before this PR change it doesn't even render on the website so I just removed it.

maybe, just add a Github issue to revisit this?

Sure, can do, will do it after PR merge so I can point the issue to correct part of code.

In case it is not clear, the @java block would only show if Java is selected in the nav bar.

But, indeed, no need to fix it now.

In case it is not clear, the @java block would only show if Java is selected in the nav bar.

Ah I see, but yes I will make an issue on this

jrudolph · 2023-02-14T09:45:58Z

docs/src/test/scala/docs/http/scaladsl/Http2Spec.scala

 //#bindAndHandleSecure
 //#bindAndHandlePlain
-import akka.http.scaladsl.Http
+import org.apache.pekko


The structure of the imports and how they are referenced into the docs seems to have changed here, was that intended?

Yes, if you check the rendered docs with sbt paradox you can see why I need to change the imports statements.

jrudolph · 2023-02-14T09:51:28Z

http-core/src/main/java/akka/http/javadsl/model/AttributeKeys.java

- * Copyright (C) 2019-2022 Lightbend Inc. <https://www.lightbend.com>
- */
-
-package akka.http.javadsl.model;


For a bunch of those files, the changes seem to be big enough that git does not detect the move any more, I guess not a big problem in practice, though.

For git diff it seems adding the parameter -M1 works (consider renamed when only 10% of the file are the same, instead of default 50%).

For git blame adding -C helps to get the original commits.

mdedetrich · 2023-02-14T10:38:09Z

The only significant to PekkoDependency is the change of the default, isn't it? And that sounds somewhat reasonable for now (it might become a bit inefficient for development if we automatically choose a new nightly every day and invalidate sbt caches on our machines, but if that becomes a problem we could also fix on a certain version for the time being).

Yes this is correct, I actually want to make an issue on this because my current impressions is this part of the build seems quite over-engineered but lets talk about it in the future issue I am talking about.

mdedetrich · 2023-02-14T11:10:13Z

Okay so I am going to go ahead and merge this, will also make an issue regarding #34 (comment)

mdedetrich · 2023-02-14T11:29:56Z

Issue regarding removed text created at #42

mdedetrich marked this pull request as draft February 5, 2023 10:12

mdedetrich force-pushed the rename-akka-package-to-pekko branch 8 times, most recently from d9e8059 to f9deacf Compare February 6, 2023 09:39

mdedetrich force-pushed the rename-akka-package-to-pekko branch from f9deacf to 4f8adbf Compare February 6, 2023 11:14

mdedetrich force-pushed the rename-akka-package-to-pekko branch 6 times, most recently from fc8a08c to 8f29425 Compare February 6, 2023 13:12

This was referenced Feb 8, 2023

Investigate switching to Pekko due to OS license change swagger-akka-http/swagger-akka-http#373

Open

change conf files so that prop names start with pekko instead of akka #25

Closed

mdedetrich force-pushed the rename-akka-package-to-pekko branch 2 times, most recently from a5e413f to 8f8448d Compare February 13, 2023 09:43

Rename akka package to org.apache.pekko

38af0a2

mdedetrich force-pushed the rename-akka-package-to-pekko branch from 8f8448d to 38af0a2 Compare February 13, 2023 09:51

mdedetrich marked this pull request as ready for review February 13, 2023 10:24

mdedetrich requested review from pjfanning and jrudolph February 13, 2023 10:24

mdedetrich requested review from gmethvin, He-Pin, nvollmar and seglo February 13, 2023 10:24

pjfanning approved these changes Feb 13, 2023

View reviewed changes

jrudolph approved these changes Feb 14, 2023

View reviewed changes

mdedetrich merged commit 00ca348 into apache:main Feb 14, 2023

mdedetrich deleted the rename-akka-package-to-pekko branch February 14, 2023 11:12

mdedetrich mentioned this pull request Feb 14, 2023

Restore the removed text from handling-blocking-operations-in-pekko-http-routes.md #42

Closed

mdedetrich mentioned this pull request Feb 18, 2023

Change akka typesafe conf to pekko #72

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename akka package to org.apache.pekko #34

Rename akka package to org.apache.pekko #34

mdedetrich commented Feb 5, 2023 •

edited

Loading

mdedetrich commented Feb 6, 2023

jrudolph commented Feb 6, 2023

mdedetrich commented Feb 6, 2023 •

edited

Loading

jrudolph commented Feb 6, 2023

mdedetrich commented Feb 6, 2023

mdedetrich commented Feb 13, 2023 •

edited

Loading

pjfanning left a comment

mdedetrich commented Feb 13, 2023

jrudolph commented Feb 14, 2023

jrudolph left a comment

jrudolph Feb 14, 2023

mdedetrich Feb 14, 2023 •

edited

Loading

pjfanning Feb 14, 2023

mdedetrich Feb 14, 2023 •

edited

Loading

jrudolph Feb 14, 2023

jrudolph Feb 14, 2023

mdedetrich Feb 14, 2023

jrudolph Feb 14, 2023

mdedetrich Feb 14, 2023

jrudolph Feb 14, 2023

jrudolph Feb 14, 2023

mdedetrich commented Feb 14, 2023 •

edited

Loading

mdedetrich commented Feb 14, 2023

mdedetrich commented Feb 14, 2023

Rename akka package to org.apache.pekko #34

Rename akka package to org.apache.pekko #34

Conversation

mdedetrich commented Feb 5, 2023 • edited Loading

mdedetrich commented Feb 6, 2023

jrudolph commented Feb 6, 2023

mdedetrich commented Feb 6, 2023 • edited Loading

jrudolph commented Feb 6, 2023

mdedetrich commented Feb 6, 2023

mdedetrich commented Feb 13, 2023 • edited Loading

pjfanning left a comment

Choose a reason for hiding this comment

mdedetrich commented Feb 13, 2023

jrudolph commented Feb 14, 2023

jrudolph left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdedetrich Feb 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdedetrich Feb 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdedetrich commented Feb 14, 2023 • edited Loading

mdedetrich commented Feb 14, 2023

mdedetrich commented Feb 14, 2023

mdedetrich commented Feb 5, 2023 •

edited

Loading

mdedetrich commented Feb 6, 2023 •

edited

Loading

mdedetrich commented Feb 13, 2023 •

edited

Loading

mdedetrich Feb 14, 2023 •

edited

Loading

mdedetrich Feb 14, 2023 •

edited

Loading

mdedetrich commented Feb 14, 2023 •

edited

Loading