support jackson buffer recycler #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
pjfanning
force-pushed
the
jackson-recycler
branch
from
e9f9ac7
to
17e2bed
Compare
pjfanning
changed the title
pjfanning
requested review from
raboof,
He-Pin,
mdedetrich,
Roiocam and
jxnu-liguobin
He-Pin
approved these changes
Mar 27, 2024
| .build(); | ||
| return new JsonMapper(jsonFactory); | ||
| } | ||
|
|
||
| private static RecyclerPool<BufferRecycler> getBufferRecyclerPool(final Config cfg) { | ||
| switch (cfg.getString("buffer-recycler.pool-instance")) { |
There was a problem hiding this comment.
As it's been used in the exceptions, how about extract to a local val？
There was a problem hiding this comment.
And maybe we can assert it should be null too.
There was a problem hiding this comment.
it is defaulted in reference.conf - virtually every config would blow up if we didn't have defaults - nowhere do we need to check for them not being set - because we have defaults in reference.conf
He-Pin
reviewed
Mar 27, 2024
...va/http-jackson/src/main/java/org/apache/pekko/http/javadsl/marshallers/jackson/Jackson.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see apache/pekko#1192