Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lost dependency(scala-java8-compat) for doc #182

Merged
merged 4 commits into from
Mar 31, 2024

Conversation

laglangyue
Copy link
Contributor

No description provided.

@laglangyue
Copy link
Contributor Author

some ci failed, so I check the file jdoc.cleanup.CleanupDocExample
import scala.compat.java8.FutureConverters;

@pjfanning
Copy link
Contributor

We have a Pekko FutureConverters class but it can only be imported from org.apache.pekko classes and this class is not in that package. So this change is needed.

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 7dffb32 into apache:main Mar 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants