-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: durable state database support #158
Conversation
how to test it,is there any integration testing? |
core/src/main/scala/org/apache/pekko/persistence/jdbc/state/DurableStateQueries.scala
Outdated
Show resolved
Hide resolved
...la/org/apache/pekko/persistence/jdbc/integration/ScalaJdbcDurableStateChangesByTagTest.scala
Outdated
Show resolved
Hide resolved
Would it be possible to add string constants for all these Strings?
And then to remove the direct usage of the strings - use the constants instead. |
Definite +1 from me |
...la/org/apache/pekko/persistence/jdbc/integration/ScalaJdbcDurableStateChangesByTagTest.scala
Outdated
Show resolved
Hide resolved
7d3c9e9
to
7ce844a
Compare
7ce844a
to
e593ff7
Compare
It may need another separate PR for MySQL support. |
Unfortunately, the Oracle integration tests are failing due to table name issues. |
Seems like latest commit break this, I will figure out later |
fixed |
@Roiocam can you create an issue for following up with MySQL support - so at least, the issue is there for other users to examine and maybe provide a solution? |
core/src/main/scala/org/apache/pekko/persistence/jdbc/state/SequenceNextValUpdater.scala
Outdated
Show resolved
Hide resolved
...cala/org/apache/pekko/persistence/jdbc/integration/ScalaJdbcDurableStateStoreQueryTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateSpec.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/pekko/persistence/jdbc/state/SequenceNextValUpdater.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/pekko/persistence/jdbc/state/SequenceNextValUpdater.scala
Outdated
Show resolved
Hide resolved
All suggestions have been applied, there are the changes: https://github.com/apache/pekko-persistence-jdbc/pull/158/files/1d3b1e5bf22ac6f7a3cf8c68fd0ad883f3d7bd84..c7bc649641a01c9471754852398d4f44299d9023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Motivation
resolves: #56
tracker
MySQL support: MySQL has very different ways to generate auto increment column