Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: durable state database support #158

Merged
merged 28 commits into from
Apr 19, 2024

Conversation

Roiocam
Copy link
Member

@Roiocam Roiocam commented Mar 20, 2024

Motivation

resolves: #56

tracker

  • MySQL support: MySQL has very different ways to generate auto increment column
  • Oracle support
  • SqlServer support
  • update documentation

@Roiocam Roiocam marked this pull request as draft March 20, 2024 09:04
@laglangyue
Copy link
Contributor

how to test it,is there any integration testing?

@pjfanning
Copy link
Contributor

Would it be possible to add string constants for all these Strings?

      case PostgresProfile  => "Postgres"
      case MySQLProfile     => "MySQL"
      case OracleProfile    => "Oracle"
      case SQLServerProfile => "SqlServer"
      case H2Profile        => "H2"

And then to remove the direct usage of the strings - use the constants instead.

@mdedetrich
Copy link
Contributor

Would it be possible to add string constants for all these Strings?

      case PostgresProfile  => "Postgres"
      case MySQLProfile     => "MySQL"
      case OracleProfile    => "Oracle"
      case SQLServerProfile => "SqlServer"
      case H2Profile        => "H2"

And then to remove the direct usage of the strings - use the constants instead.

Definite +1 from me

@Roiocam Roiocam force-pushed the durable-state-support branch 2 times, most recently from 7d3c9e9 to 7ce844a Compare March 30, 2024 16:00
@Roiocam Roiocam marked this pull request as ready for review April 3, 2024 07:23
@Roiocam
Copy link
Member Author

Roiocam commented Apr 3, 2024

It may need another separate PR for MySQL support.

@Roiocam Roiocam requested review from He-Pin and pjfanning April 8, 2024 01:52
@pjfanning
Copy link
Contributor

Unfortunately, the Oracle integration tests are failing due to table name issues.

@Roiocam
Copy link
Member Author

Roiocam commented Apr 8, 2024

Unfortunately, the Oracle integration tests are failing due to table name issues.

Seems like latest commit break this, I will figure out later

@Roiocam
Copy link
Member Author

Roiocam commented Apr 8, 2024

Unfortunately, the Oracle integration tests are failing due to table name issues.

fixed

@pjfanning
Copy link
Contributor

@Roiocam can you create an issue for following up with MySQL support - so at least, the issue is there for other users to examine and maybe provide a solution?

@Roiocam
Copy link
Member Author

Roiocam commented Apr 9, 2024

@Roiocam can you create an issue for following up with MySQL support - so at least, the issue is there for other users to examine and maybe provide a solution?

#174 created.

@Roiocam
Copy link
Member Author

Roiocam commented Apr 9, 2024

@Roiocam Roiocam requested review from He-Pin and pjfanning April 9, 2024 15:36
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Roiocam Roiocam merged commit 8df083a into apache:main Apr 19, 2024
20 checks passed
@Roiocam Roiocam deleted the durable-state-support branch April 19, 2024 03:34
@pjfanning pjfanning added this to the 1.1.0-M1 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make DurableState possible to use with other databases
6 participants