Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use long values instead of int values #101

Merged
merged 2 commits into from
Mar 24, 2024
Merged

use long values instead of int values #101

merged 2 commits into from
Mar 24, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Mar 23, 2024 •
edited

Still a question as to how far we want to go with these changes.

See #90

@pjfanning pjfanning marked this pull request as draft March 23, 2024 20:07
@pjfanning pjfanning mentioned this pull request Mar 23, 2024
Merged
@pjfanning pjfanning marked this pull request as ready for review March 23, 2024 20:15
He-Pin
He-Pin approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

But it's not a binary compatible change, should be mentioned in release note.

@pjfanning pjfanning added the release notes should be mentioned in release notes label Mar 24, 2024
mdedetrich
mdedetrich approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should probably add migration notes in same style as pekko so people are aware

@pjfanning pjfanning mentioned this pull request Mar 24, 2024
Open
@pjfanning
Copy link
Contributor Author

created #103

@pjfanning pjfanning merged commit 583e576 into apache:main Mar 24, 2024
20 checks passed
@pjfanning pjfanning deleted the use-long branch March 24, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He-Pin He-Pin He-Pin approved these changes

@mdedetrich mdedetrich mdedetrich approved these changes

@raboof raboof Awaiting requested review from raboof

@samueleresca samueleresca Awaiting requested review from samueleresca

@Roiocam Roiocam Awaiting requested review from Roiocam

@jxnu-liguobin jxnu-liguobin Awaiting requested review from jxnu-liguobin

Assignees
No one assigned
Labels
release notes should be mentioned in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pjfanning @He-Pin @mdedetrich