Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-paradox to 0.10.6 #1061

Closed
wants to merge 1 commit into from

Conversation

scala-steward-asf[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates com.lightbend.paradox:sbt-paradox from 0.9.2 to 0.10.6

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.lightbend.paradox", artifactId = "sbt-paradox" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lightbend.paradox", artifactId = "sbt-paradox" }
}]
labels: sbt-plugin-update, early-semver-major, semver-spec-minor, commit-count:1

@mkurz
Copy link
Contributor

mkurz commented Jan 28, 2024

Tests fails (https://github.com/apache/incubator-pekko/actions/runs/7681954241/job/20935690091?pr=1061#step:7:32954)

[01-28 00:57:25.993] [error] java.lang.UnsupportedClassVersionError: org/parboiled/trees/GraphNode has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

Parboiled upgrades from 1.3.1 to 1.4.1: lightbend/paradox@v0.9.2...v0.10.6#diff-ad2642dc77b3679e4ad2c7d3b2f59a2dcf48c1bf5b93a558a4fa44828315a34cR23

1.4.1 drops support for Java 8: https://github.com/sirthias/parboiled/blob/7f6d999ba9a838ea760f00a1dc85eac91ed515e6/CHANGELOG#L1-L4

Solution might be to force use version 1.4.0? What do you think?

@mkurz
Copy link
Contributor

mkurz commented Jan 28, 2024

Ah ok I just saw this comment

// We have to deliberately use older versions of sbt-paradox because current Pekko sbt build
// only loads on JDK 1.8 so we need to bring in older versions of parboiled which support JDK 1.8

How about instead of holding back all those paradox dependencies, using dependencyOverrides to force Parboiled to version 1.4.0?

@pjfanning
Copy link
Contributor

@mkurz is the sbt repo being shut down? We have a lot of other stuff going on and it would be a pain to drop everything to to focus on paradox builds.

@mkurz
Copy link
Contributor

mkurz commented Jan 28, 2024

@pjfanning No, it's not shutting down. But who knows when it's going down again. It's not urgent, I just want to raise awareness and start migrating stuff that hasn't yet, not much missing actually. I can already build and test Play locally by only using maven central dependencies.

@mkurz
Copy link
Contributor

mkurz commented Jan 28, 2024

Actually, bumping sbt-paradox to 0.10.6 is the last piece missing to make pekko compile and test with having repo.scala-sbt.org blocked (of course with all artifacts from that repo removed from the local cache).

@mdedetrich
Copy link
Contributor

How about instead of holding back all those paradox dependencies, using dependencyOverrides to force Parboiled to version 1.4.0?

if this works sure

Another solution would be to make sbt-paradox have another release in the 0.9.x series onto the new repo (maybe even backporting some fixes!) but I am not sure if thats on the table

@mdedetrich
Copy link
Contributor

Closing this for now since this problem is being solved another way

@mdedetrich mdedetrich closed this Feb 18, 2024
@mdedetrich mdedetrich deleted the update/sbt-paradox-0.10.6 branch February 18, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants