-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional mailbox selector for typed props #1096
base: main
Are you sure you want to change the base?
additional mailbox selector for typed props #1096
Conversation
@Roiocam can you put the typo fixes in a separate PR? We can backfit that change. |
...yped-tests/src/test/scala/org/apache/pekko/actor/typed/scaladsl/DispatcherSelectorSpec.scala
Outdated
Show resolved
Hide resolved
parentProbe.ref) | ||
|
||
val childProbe = createTestProbe[ActorRef[Ping]]() | ||
grandParent ! SpawnProtocol.Spawn(PingPong(), "child", Props.empty.withDispatcherSameAsParent, childProbe.ref) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix children not spawn from the parent
3b83298
to
8e3f603
Compare
93fac01
to
b9b046d
Compare
d1302b7
to
7cbc958
Compare
7cbc958
to
9c1022f
Compare
actor-typed-tests/src/test/scala/docs/org/apache/pekko/typed/MailboxDocSpec.scala
Outdated
Show resolved
Hide resolved
import org.apache.pekko | ||
import pekko.actor.typed.DispatcherSelector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you reorder the imports and put back the empty line above?
Motivation
I have experience in migrating Classic to Typed. In the process, I found that Typed can't customize Mailbox through Props. We should match the same Classic method on Typed.
TODO list