Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forward fit Akka compat changes #1211

Merged
merged 3 commits into from Mar 22, 2024
Merged

forward fit Akka compat changes #1211

merged 3 commits into from Mar 22, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Mar 20, 2024 •
edited

cherry pick 27b4032, 4b78adf and 55fee70

#765, #1112

  • We haven't had much feedback on these changes in 1.0.3-M1.
  • pekko 1.0 and 1.1 have no major differences that would make it significantly harder for an Akka user to switch to pekko 1.1
  • this compat code only kicks in when you set certain configs so doesn't have an impact on most users
  • we can always remove this code in a future pekko release

He-Pin
He-Pin reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

He-Pin
He-Pin approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pjfanning
Copy link
Contributor Author

@mdedetrich do you have any objections?

@pjfanning
add default for pekko.remote.akka.version (apache#1112)
e126dbf 
* add default for pekko.cluster.akka.version

* refactor configs

* Update reference.conf

* add validations for config settings

* Update RemoteSettings.scala

* Update RemoteSettingsSpec.scala

* scalafmt
samueleresca
samueleresca approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@samueleresca samueleresca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherry picking the akka compatibility changes, looks good to me

nvollmar
nvollmar approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mdedetrich
mdedetrich approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 0646754 into apache:main Mar 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He-Pin He-Pin He-Pin approved these changes

@nvollmar nvollmar nvollmar approved these changes

@mdedetrich mdedetrich mdedetrich approved these changes

@samueleresca samueleresca samueleresca approved these changes

@raboof raboof Awaiting requested review from raboof

@Roiocam Roiocam Awaiting requested review from Roiocam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pjfanning @He-Pin @nvollmar @mdedetrich @samueleresca