Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bcprov test dependency due to CVE #1313

Merged
merged 2 commits into from
May 7, 2024
Merged

add bcprov test dependency due to CVE #1313

merged 2 commits into from
May 7, 2024

Conversation

pjfanning
Copy link
Contributor

@laglangyue
Copy link
Contributor

the link is 404

nvollmar
nvollmar approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

He-Pin
He-Pin approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

raboof
raboof reviewed May 7, 2024
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we should care about all CVEs in test dependencies.

Should we add a comment specifying when we can remove this override again?

@pjfanning pjfanning mentioned this pull request May 7, 2024
Open
@pjfanning pjfanning merged commit 42ea809 into apache:main May 7, 2024
17 of 18 checks passed
@pjfanning pjfanning deleted the bcprov branch May 7, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof left review comments

@He-Pin He-Pin He-Pin approved these changes

@nvollmar nvollmar nvollmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pjfanning @laglangyue @raboof @He-Pin @nvollmar