Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with osgi project scaladoc (scala3) #355

Merged
merged 1 commit into from
May 27, 2023

Conversation

pjfanning
Copy link
Contributor

  • this exclusion of Scala3 cross build causes the scaladoc build to fail for me
  • maybe there is a good reason to exclude this - but I don't know what it is
  • this PR change means sbt ++3.3.0 publishSigned works for me now
  • not sure why this does not seem to happen in CI build

@raboof @jrudolph would you have any ideas about this?

I had a quick look at Akka and they don't seem to have the osgi stuff any more - see akka/akka#28304

fyi @mdedetrich

@pjfanning
Copy link
Contributor Author

@mdedetrich do you think this is something we can merge and possibly modify later if someone suggests a better path?

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 45f2445 into apache:main May 27, 2023
16 checks passed
@pjfanning pjfanning deleted the osgi-scaladoc-scala3 branch May 27, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants