Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

=build Use zulu in nightly build to test jdk21. #659

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Sep 20, 2023

There is no jdk21 temurin release for now, so I have to switch to zulu or oracle :(

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - we can switch back to temurin later (when they have a jdk 21 release)

@He-Pin
Copy link
Member Author

He-Pin commented Sep 20, 2023

@pjfanning Is there any special vaue to chose temurin instead of zulu or oracle?

@mdedetrich
Copy link
Contributor

@pjfanning Is there any special vaue to chose temurin instead of zulu or oracle?

Temurin is built from official OpenJDK sources, zulu/oracle are not

@mkurz
Copy link
Contributor

mkurz commented Sep 20, 2023

fyi, we had the same problem in Play. So I created my own jvm index that contains the latest Java Temurin ea builds: https://github.com/mkurz/jvm-index/blob/adoptium_temurin_eaps/index.json
Hopefully setup-action merges my PR for for the --jvm-index at some point: coursier/setup-action#465
Meanwhile I forked the action to be able to make use of the flag: playframework/.github@631bb35 and playframework/.github@216eb92
We can now sucessfully test Temurin ea builds: https://github.com/playframework/playframework/pull/11925/files#diff-063ca77e012f959eba648db60e6868875fd1e70e5f5ac081193d848f8d61ef32R86

@He-Pin
Copy link
Member Author

He-Pin commented Sep 20, 2023

@mkurz Where to ask they for doing a 21 release?

@He-Pin He-Pin merged commit 2b0f149 into apache:main Sep 20, 2023
17 checks passed
@He-Pin He-Pin deleted the java21Zulu branch September 20, 2023 10:09
@mkurz
Copy link
Contributor

mkurz commented Sep 20, 2023

@He-Pin
First Adoptium needs to provide the Temurin 21 builds, this usually takes a couple of days:
adoptium/temurin#7
So we just have to wait here.
Then the coursier jvm-index needs to fetch that new release once it's published, so we need to adjust this line to include 21: https://github.com/coursier/jvm-index/blob/master/src/Temurin.scala#L5
Then someone needs to run that tool, like described in the README of https://github.com/coursier/jvm-index/ so the index.json in that repository gets updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants