Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala to 3.3.3 #855

Closed
wants to merge 5 commits into from
Closed

Conversation

mdedetrich
Copy link
Contributor

Scala 3.3.2-RC1 just came out so this PR is testing it out to see if the codebase compiles. It will remain in draft until full release of Scala 3.3.2 is out.

@mdedetrich mdedetrich marked this pull request as draft December 21, 2023 04:03
raboof added a commit to raboof/pekko that referenced this pull request Jan 31, 2024
Follow-up on apache#855

Gets us the fix for scala/scala3#18210
@raboof raboof mentioned this pull request Jan 31, 2024
@He-Pin
Copy link
Member

He-Pin commented Feb 28, 2024

refs: playframework/playframework#12418

Need to wait for the bug in 3.3.2 to get fixed before merge this

@mkurz
Copy link
Contributor

mkurz commented Feb 28, 2024

@pjfanning pjfanning changed the title Update Scala to 3.3.2 Update Scala to 3.3.3 Feb 29, 2024
@pjfanning
Copy link
Contributor

3.3.3 is on maven central - scala/scala3#19820 (comment)

Still would be wary of merging this even if it passes CI. I'd prefer to wait a few days to see if there are further issues.

@mdedetrich mdedetrich marked this pull request as ready for review March 1, 2024 06:55
@mdedetrich mdedetrich marked this pull request as draft March 1, 2024 06:55
@mdedetrich
Copy link
Contributor Author

mdedetrich commented Mar 1, 2024

3.3.3 is on maven central - lampepfl/dotty#19820 (comment)

Still would be wary of merging this even if it passes CI. I'd prefer to wait a few days to see if there are further issues.

We can even wait a week, M1 is in no rush for 1.1.x and 1.0.3-M1 was just released now

@He-Pin
Copy link
Member

He-Pin commented Mar 1, 2024

I think you mean 1.0.3-m1, and I think we can backport 3.3.3 to 1.0.x branch once the vote pass.

@mdedetrich
Copy link
Contributor Author

I think you mean 1.0.3-m1, and I think we can backport 3.3.3 to 1.0.x branch once the vote pass.

Yes, fixed

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich
Copy link
Contributor Author

Closing in favour of #1169 which is the same PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants