PHOENIX-5234 Create patch scripts for phoenix-connectors and phoenix-queryserver projects #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsgupta1
changed the title
nsgupta1
changed the title
ChinmaySKulkarni
requested changes
Nov 11, 2019
There was a problem hiding this comment.
Thanks for the contribution @nsgupta1! This is very useful. Please take a look at the review comments. Can you please post a screenshot of what a possible green/red build would look like?
Also, if mvn clean install fails for a PR, does this prevent the PR from being merged, or is it more like a warning?
|
|
|
If checks from PR are failing we get warnings like this example, It doesn't block from merging the PR. |
|
@nsgupta1 The URL (https://github.com/nsgupta1/Test_Action_tab/pull/2) is not accessible. Did you want to put up a public gist instead? |
|
Overall +1. Please squash all commits before we can merge. Thanks @nsgupta1 |
nsgupta1
force-pushed
the
master
branch
2 times, most recently
from
3b7b295
to
517db23
Compare
…-queryserver projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This github workflow adds a check to run phoenix-connectors integration test based on every PR and push to master branch. Authors/reviewers can view the result of it in "check" tab of PR. @vincentpoon @ChinmaySKulkarni @twdsilva can you please look into this ?