OMID-231 Build and test Omid with Hadoop 3 #117
Conversation
.gitignore
Outdated
| @@ -15,6 +15,7 @@ lib/ | |||
| *.iws | |||
| *~ | |||
| *.swp | |||
| ^dev-support/artifacts | |||
There was a problem hiding this comment.
I don't think we need the ^ character
Also I would add dev-support/work here too
There was a problem hiding this comment.
Right, that is not a regex.
| @@ -378,6 +378,8 @@ | |||
|
|
|||
| <!-- Exclude config and scripts --> | |||
| <exclude>**/dev-utils/*</exclude> | |||
| <exclude>dev-support/artifacts/**</exclude> | |||
There was a problem hiding this comment.
Also we should exclude this and dev-support/work/** folders from apache-rat-plugin
And maybe move those exclusions from a profile to apply globally but that could be handled as a separate task as it is not related to the scope of this change.
There was a problem hiding this comment.
Yes, that's not not strictly in scope, but makes testing the rat settings easier.
|
I hopefully fixed the problems you found, please check again. |
There was a problem hiding this comment.
Thank you Istvan for the fix.
Now I have only the bintray-settings.xml found by rat check but I'll handle that as part of OMID-189
No description provided.