OMID-254 Upgrade to phoenix-thirdparty 2.1.0 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Built code locally and ran tests.: FYI @chrajeshbabu , @stoty , @gjacoby126 |
|
+1 lgtm |
chrajeshbabu
approved these changes
Dec 22, 2023
|
Have you run the full Phoenix test suite with both Phoenix and Omid built with the new thirdparty, @NihalJain ? |
Hi @stoty I have ran following for omid.
Also had run tests for phoenix with apache/phoenix-thirdparty#8 (comment). I had done this test with omid snapshot having 3rd party change with following command: It's been a while let me know, if you want me to retrigger with latest changes. |
|
No need, if you have tested with thirdparty-2.1 in both Omid and Phoenix at the same time, that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.