OMID-202 Refactor Omid to use Netty 4 #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoty
requested review from
chrajeshbabu,
joshelser,
ankitsinghal and
virajjasani
joshelser
reviewed
Mar 19, 2021
| @@ -342,7 +344,7 @@ public void nodeChanged() throws Exception { | |||
| setTSOAddress(hp.getHost(), hp.getPort()); | |||
| epoch = Long.parseLong(currentTSOAndEpochArray[1]); | |||
| LOG.info("CurrentTSO ZNode changed. New TSO Host & Port {}/Epoch {}", hp, getEpoch()); | |||
| if (currentChannel != null && currentChannel.isConnected()) { | |||
| if (currentChannel != null && currentChannel.isActive()) { | |||
There was a problem hiding this comment.
Might be nice to consolidate this into a helper since you're modifying it.
There was a problem hiding this comment.
Which part do you mean ?
This handles the case when the active server changes in ZK, and AFAICT this is the only place where it is handled.
There was a problem hiding this comment.
Ah, sorry, I was suggesting to consolidate these two things into one method, aka boolean isChannelActive(Channel) { return channel != null && channel.isActive();}
Can ignore if you don't think there's value in it :)
transaction-client/src/main/java/org/apache/omid/tso/client/TSOClient.java
Show resolved
Hide resolved
transaction-client/src/main/java/org/apache/omid/tso/client/TSOClient.java
Show resolved
Hide resolved
joshelser
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.