Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-6410 Expose primary keys metadata via SqlAlchemy #64

Closed
wants to merge 1 commit into from
Closed

PHOENIX-6410 Expose primary keys metadata via SqlAlchemy #64

wants to merge 1 commit into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented May 17, 2021

No description provided.

@stoty stoty requested a review from joshelser May 17, 2021 12:23
@romainr
Copy link

romainr commented May 17, 2021

I can see for pip installing your branch and testing within Hue

@romainr
Copy link

romainr commented May 18, 2021

Nice!

image

romainr
romainr approved these changes May 18, 2021
View reviewed changes
Copy link

@romainr romainr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also confirming we can get the indexes

[{'name': 'GLOBAL_IDX', 'unique': True, 'column_names': ['0:MESSAGE', ':ID']}]

python-phoenixdb/phoenixdb/tests/test_db.py Outdated
self.assertEqual(meta.get_index_info(table='NON_EXISTENT'), [])

self.assertTrue(len(meta.get_index_info(table='DEFAULT_TABLE')) > 1)
print(meta.get_index_info(table='DEFAULT_TABLE'))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: print

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX, done.

@stoty
Copy link
Contributor Author

stoty commented May 18, 2021

I have also added some post-processing in the SQLAlchemy index column list to get the expected name when there is no column family trickery.

@stoty stoty closed this May 19, 2021
joshelser
joshelser reviewed May 20, 2021
View reviewed changes
Copy link
Member

@joshelser joshelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belated +1 from me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshelser joshelser joshelser left review comments

@romainr romainr romainr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@stoty @romainr @joshelser