PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty #2
Conversation
includes a patch that lets us disable the double quote removing "feature"
| - currentOption.addValueForProcessing(Util.stripLeadingAndTrailingQuotes(token)); | ||
| + currentOption.addValueForProcessing(conditionallyStripLeadingAndTrailingQuotes(token)); |
There was a problem hiding this comment.
This gets applied when we build phoenix-thirdparty?
There was a problem hiding this comment.
Also, 254 in CLI-254 is somehow relevant in commons-cli or is it just a number that we provide in patch file?
There was a problem hiding this comment.
Yes. The pom was copied from hbase-thirdparty:hbase-shaded-protobuf with minimal changes.
The patch is a backport of my proposed fix for https://issues.apache.org/jira/browse/CLI-254
apache/commons-cli#58
to commons-cli 1.4
| <includes> | ||
| <include>**/**</include> | ||
| </includes> |
There was a problem hiding this comment.
You're right.
I left it in when removing the exclusions when copying this from hbase-shaded-porotobuf.
phoenix-shaded-commons-cli/pom.xml
Outdated
| src/main/java)--> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-dependency-plugin</artifactId> | ||
| <version>3.1.1</version> |
There was a problem hiding this comment.
Would be good to pull versions into pluginManagement in the parent in a follow-on.
There was a problem hiding this comment.
I'll update it in a few minutes.
|
Thanks for the reviews @virajjasani @joshelser |
includes a patch that lets us disable the double quote removing "feature"