Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6242 Remove remaining commons-logging references #1001

Closed
wants to merge 1 commit into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Dec 3, 2020

No description provided.

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for keeping all loggers private, everything looks good. Confirmed locally that all places are covered.

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (non-binding)

@stoty
Copy link
Contributor Author

stoty commented Dec 3, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+0 🆗 mvndep 0m 30s Maven dependency ordering for branch
+1 💚 mvninstall 11m 44s 4.x passed
+1 💚 compile 1m 40s 4.x passed
+1 💚 checkstyle 0m 57s 4.x passed
+1 💚 javadoc 2m 9s 4.x passed
+0 🆗 spotbugs 5m 17s root in 4.x has 1004 extant spotbugs warnings.
+0 🆗 spotbugs 3m 43s phoenix-core in 4.x has 950 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 6m 29s the patch passed
+1 💚 compile 1m 31s the patch passed
+1 💚 javac 1m 31s the patch passed
-1 ❌ checkstyle 0m 54s root: The patch generated 12 new + 1009 unchanged - 13 fixed = 1021 total (was 1022)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 51s the patch passed
+1 💚 spotbugs 7m 57s the patch passed
_ Other Tests _
-1 ❌ unit 190m 30s root in the patch failed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
240m 43s
Reason Tests
Failed junit tests phoenix.end2end.index.IndexCoprocIT
phoenix.end2end.index.MutableIndexIT
TEST-[RangeScanIT_2]
phoenix.end2end.RowValueConstructorOffsetIT
phoenix.end2end.IndexExtendedIT
phoenix.end2end.SequenceIT
phoenix.end2end.SkipScanQueryIT
phoenix.end2end.AlterTableIT
phoenix.end2end.index.GlobalImmutableTxIndexIT
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1001/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1001
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml
uname Linux f4e874fb6b16 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / 5e70f76
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1001/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1001/2/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1001/2/testReport/
Max. process+thread count 6065 (vs. ulimit of 30000)
modules C: phoenix-core . U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1001/2/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.4
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@gjacoby126 gjacoby126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks @stoty

@gjacoby126
Copy link
Contributor

JIRA is marked resolved, closing PR.

@gjacoby126 gjacoby126 closed this Dec 8, 2020
@stoty stoty deleted the PHOENIX-6242-4.x branch July 29, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants